beam icon indicating copy to clipboard operation
beam copied to clipboard

fix: generate random index name for change streams

Open thiagotnunes opened this issue 1 year ago • 8 comments

Generates index names for change stream partition metadata table using a random UUID. This prevents issues if the job is being redeployed in an existing database.

thiagotnunes avatar Oct 08 '24 03:10 thiagotnunes

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Oct 08 '24 07:10 github-actions[bot]

retest this please

thiagotnunes avatar Oct 08 '24 23:10 thiagotnunes

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java. R: @ahmedabu98 for label io. R: @nielm for label spanner.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Oct 09 '24 06:10 github-actions[bot]

Is this a fix for issue #32509? If so, can you add a "fixes: " in the description please? @thiagotnunes

nielm avatar Oct 11 '24 10:10 nielm

LGTM

nielm avatar Oct 11 '24 10:10 nielm

@nielm no, it is not a fix for #32509. AFAIU that issue happens, because the user cannot specify a table schema for the metadata table.

thiagotnunes avatar Oct 13 '24 22:10 thiagotnunes

@ahmedabu98 for next reviewer in chain

nielm avatar Oct 15 '24 07:10 nielm

gentle ping @ahmedabu98 =)

thiagotnunes avatar Oct 17 '24 22:10 thiagotnunes