beam icon indicating copy to clipboard operation
beam copied to clipboard

SolaceIO: refactor to allow inheritance of BasicAuthSempClient

Open bzablocki opened this issue 1 year ago • 1 comments

Users were not able to create a custom BasicAuthSempClient due to some package-private fields. This PR fixes that and adds example on how to create and use a custom client.

Depends on https://github.com/apache/beam/pull/32060, waiting for that to be merged


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

bzablocki avatar Sep 05 '24 14:09 bzablocki

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Sep 05 '24 15:09 github-actions[bot]

Reopening after an error with rebase

bzablocki avatar Nov 13 '24 16:11 bzablocki

Run Java PreCommit

bzablocki avatar Nov 13 '24 17:11 bzablocki

Run Java_Solace_IO_Direct PreCommit

bzablocki avatar Nov 25 '24 14:11 bzablocki

Run Java_Examples_Dataflow PreCommit

bzablocki avatar Nov 25 '24 17:11 bzablocki

@Abacn now that @sjvanrossum lgtm'ed, can I ask you for a review?

bzablocki avatar Nov 26 '24 11:11 bzablocki