beam icon indicating copy to clipboard operation
beam copied to clipboard

Rag opensearch usecase with Beam's MLTransform

Open itsayushpandey opened this issue 1 year ago • 5 comments

Added Insertion and Enrichment pipeline for RAG (Retrival Augmented Generation) usecase using OpenSearch vector database #GSOC-259


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

itsayushpandey avatar Jul 30 '24 06:07 itsayushpandey

R: @damccorm @jrmccluskey

itsayushpandey avatar Jul 30 '24 06:07 itsayushpandey

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Jul 30 '24 06:07 github-actions[bot]

I'd recommend rebasing the PR now that the initial RAG PR is merged

jrmccluskey avatar Aug 12 '24 14:08 jrmccluskey

@jrmccluskey - thanks for the review suggestions! I have made changes as per your feedback, please let me know if these look good.

itsayushpandey avatar Aug 21 '24 03:08 itsayushpandey

Code looks good, probably time to focus on cleaning up the notebook

Same note on rebasing the branch, see https://stackoverflow.com/questions/7929369/how-to-rebase-local-branch-onto-remote-master/18442755#18442755

@jrmccluskey - the branch seems upto date with master This branch has no conflicts with the base branch. Am I misunderstanding something?

itsayushpandey avatar Aug 23 '24 01:08 itsayushpandey

@itsayushpandey I think this is the problem:

image

Your branch doesn't contain the most recent set of changes. To fix, you can:

git remote add upstream https://github.com/apache/beam.git
git fetch upstream
git rebase upstream/main

damccorm avatar Sep 05 '24 15:09 damccorm

Hi @damccorm - the trailing commits of branch should have been updated. Can you please check if this looks good to go now? image

itsayushpandey avatar Sep 14 '24 00:09 itsayushpandey