Support custom JdbcReadWithPartitionsHelper for Jdbc.ReadWithPartitions
Fix #31419
String sorting is more complex than integers / datetimes (the field can be alpha-numeric; base64; alphabetic; etc, and other scenarios). The solution here is to support custom JdbcReadWithPartitionsHelper.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
In fact, the original implementation #15848 entitled "An any-type implementation for readWithPartitions". It pretty much provided the interface to support any-type for readWithPartitions, but not exposed JdbcReadWithPartitionsHelper as public API.
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @kennknowles for label java. R: @ahmedabu98 for label io.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
R: @Amar3tto
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control