beam icon indicating copy to clipboard operation
beam copied to clipboard

[Dataflow Streaming] Enabled Heartbeat by Default

Open TongruiLi opened this issue 1 year ago • 3 comments

This sets heartbeat work by default and will rollout along next beam release. This CL also refactors and fixed some unit test issues.

TongruiLi avatar Jun 26 '24 08:06 TongruiLi

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Jun 26 '24 08:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.37%. Comparing base (5a09095) to head (5c1fa0e).

:exclamation: Current head 5c1fa0e differs from pull request most recent head 3f97733

Please upload reports for the commit 3f97733 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #31689      +/-   ##
============================================
+ Coverage     71.18%   71.37%   +0.19%     
+ Complexity     3019     1474    -1545     
============================================
  Files          1058      900     -158     
  Lines        134254   114202   -20052     
  Branches       3257     1076    -2181     
============================================
- Hits          95571    81515   -14056     
+ Misses        35536    30659    -4877     
+ Partials       3147     2028    -1119     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 26 '24 20:06 codecov[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Jun 26 '24 21:06 github-actions[bot]

assign set of reviewers

TongruiLi avatar Jul 01 '24 07:07 TongruiLi

Reviewers are already assigned to this PR: @robertwb

github-actions[bot] avatar Jul 01 '24 07:07 github-actions[bot]