apache
PubsubMessageWithTopicCoder.of() is returning wrong coder
PubsubMessageWithTopicCoder should return PubsubMessageWithTopicCoder PubsubMessageWithAttributesAndMessageIdCoder.
While investigating Dynamic Destinations on Direct runner I found out that PubsubMessageWithTopicCoder is never used and topic is lost and pipeline fails.
fixes #31679
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @m-trieu for label java. R: @chamikaramj for label io.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@stankiewicz do you mind also cleaning up the one occurrence of new PubsubMessageWithTopicCoder() here to use PubsubMessageWithTopicCoder.of() instead?
Ah, wow. Thanks for the fix.
Out of curiosity, did you actually run into a failure due to this ? Also, would you mind filing a Github issue with details and the actual failure you potentially ran into ?
Thanks LGTM.
Seems like this was added in https://github.com/apache/beam/pull/26063/files
cc: @reuvenlax in case we are missing something here.
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:
R: @robertwb for label java. R: @ahmedabu98 for label io.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:
R: @Abacn for label java. R: @damondouglas for label io.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)