beam icon indicating copy to clipboard operation
beam copied to clipboard

Solace Read connector: adding implementations of SempClient and SempClientFactory

Open bzablocki opened this issue 1 year ago • 1 comments

This is the 4th PR for the Solace Read connector (addresses #31440). It depends on the #31541, #31539 and #31476 (root).

The files that are added/modified in this PR, comparing to the #31541:

  • build.gradle
  • BasicAuthSempClient.java
  • BasicAuthSempClientFactory.java
  • BrokerResponse.java
  • SempBasicAuthClientExecutor.java
  • Semp.java
  • package-info.java
  • SerializableSupplier.java
  • SempBasicAuthClientExecutorTest.java

Quick Link to see only the modified files: https://github.com/apache/beam/pull/31542/commits/43adbb7b06fde01aa126a8999cdad318c03069c4

These are implementations of SempClient and SempClientFactory. SempClientFactory can be used as an argument to SolaceIO.Read.withSempClientFactory(...).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

bzablocki avatar Jun 07 '24 10:06 bzablocki

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Jun 07 '24 11:06 github-actions[bot]

assign set of reviewers

bzablocki avatar Jul 02 '24 08:07 bzablocki

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Jul 02 '24 08:07 github-actions[bot]