beam icon indicating copy to clipboard operation
beam copied to clipboard

enable BigQueryIO read throttling detection for Python SDK

Open Abacn opened this issue 1 year ago • 1 comments

Before (using a gcp project of limited quota):

image

upscale to 270+ worker aggressively, before cancel the job

After (note: backend change not yet rolled out on prod):

(up-hill part, max worker=181) image

(down-hill part) image

note: autoscaler won't kill active worker until current work item finish, and there is a 6 min lapse from worker started to reactive downscale working, see https://github.com/apache/beam/pull/31253#issuecomment-2118608486

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Abacn avatar May 24 '24 22:05 Abacn

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 25 '24 00:05 github-actions[bot]

R: @shunping @ahmedabu98

Abacn avatar May 28 '24 13:05 Abacn

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar May 28 '24 13:05 github-actions[bot]

Python ML test failure on 2/5 python versions unrelated to the change. Merging for now.

Abacn avatar May 28 '24 23:05 Abacn