beam icon indicating copy to clipboard operation
beam copied to clipboard

[ManagedIO] pass underlying transform URN as an annotation

Open ahmedabu98 opened this issue 1 year ago • 2 comments

ahmedabu98 avatar May 24 '24 18:05 ahmedabu98

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.17%. Comparing base (1f63196) to head (974dcb7). Report is 53 commits behind head on master.

:exclamation: Current head 974dcb7 differs from pull request most recent head 8de4529

Please upload reports for the commit 8de4529 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #31398      +/-   ##
============================================
+ Coverage     68.55%   71.17%   +2.62%     
+ Complexity    14921     2996   -11925     
============================================
  Files          2636     1068    -1568     
  Lines        222092   133696   -88396     
  Branches      11826     3245    -8581     
============================================
- Hits         152250    95164   -57086     
+ Misses        63647    35400   -28247     
+ Partials       6195     3132    -3063     
Flag Coverage Δ
java 69.45% <ø> (+3.72%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 20:05 codecov[bot]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar May 24 '24 22:05 github-actions[bot]

Thanks for the review @chamikaramj, PTAL

ahmedabu98 avatar May 28 '24 19:05 ahmedabu98

FYI @chamikaramj, I had to move the test out of core because it required a dependency on managed, which results in a circular dependency.

ahmedabu98 avatar May 30 '24 15:05 ahmedabu98

Test failures are unrelated

ahmedabu98 avatar May 30 '24 21:05 ahmedabu98