beam icon indicating copy to clipboard operation
beam copied to clipboard

Add try-excepts around data sampler encoding

Open rohdesamuel opened this issue 1 year ago • 4 comments

Add try-excepts around data sampler encoding


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

rohdesamuel avatar May 24 '24 17:05 rohdesamuel

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 24 '24 18:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.62%. Comparing base (b34cf54) to head (7677083). Report is 280 commits behind head on master.

Files Patch % Lines
.../python/apache_beam/runners/worker/data_sampler.py 55.55% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #31396      +/-   ##
============================================
+ Coverage     71.44%   77.62%   +6.18%     
- Complexity     1474     2980    +1506     
============================================
  Files           906      760     -146     
  Lines        113271    95406   -17865     
  Branches       1076     3229    +2153     
============================================
- Hits          80931    74063    -6868     
+ Misses        30327    19880   -10447     
+ Partials       2013     1463     -550     
Flag Coverage Δ
go ?
python 81.36% <55.55%> (-0.16%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 20:05 codecov[bot]

R: @KevinGG

rohdesamuel avatar May 24 '24 23:05 rohdesamuel

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar May 24 '24 23:05 github-actions[bot]