beam icon indicating copy to clipboard operation
beam copied to clipboard

Add option to disable validation of cloud bigtable change stream IO

Open tonytanger opened this issue 1 year ago • 5 comments

fixes #31360 Add withoutValidation option to Bigtable change stream IO.

This aligns with withoutValidation of Read and Write IO. This allows users to create a pipeline without validating the correctness of the change stream configurations. This includes validating the change stream table exists, metadata table exists, metadata table is using the correct schema, and app profile used is appropriate. This allows the users to create a pipeline without Bigtable permissions locally. Bigtable permissions is still required by the pipeline itself in order to stream the table.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

tonytanger avatar May 22 '24 21:05 tonytanger

@jackdingilian for Bigtable review.

tonytanger avatar May 23 '24 15:05 tonytanger

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java. R: @johnjcasey for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 23 '24 15:05 github-actions[bot]

I added some unit tests for the ReadChangeStream config.

tonytanger avatar May 23 '24 19:05 tonytanger

@svetakvsundhar we're ready to merge. Thanks.

tonytanger avatar May 24 '24 17:05 tonytanger

Sounds good. Will merge after CI completes! Thanks for the quick turnaround!

svetakvsundhar avatar May 24 '24 17:05 svetakvsundhar

Note: The failures are unrelated to this change. Going to merge.

svetakvsundhar avatar May 28 '24 15:05 svetakvsundhar