beam icon indicating copy to clipboard operation
beam copied to clipboard

[Feature Request]: Manage GCS soft delete policy in temp location

Open shunping opened this issue 1 year ago • 1 comments

What would you like to happen?

Background

GCS has introduced soft delete policy feature in new and existing buckets since March 2024. By default, the soft delete retention period is 7 days. (https://cloud.google.com/resources/storage/soft-delete-announce?hl=en)

This feature may impact Beam users who use temp and staging locations in GCS for temporary files and pipeline execution, because storage during the soft delete window will still be billed.

Tasks

  • [ ] Disable soft delete policy when creating a new default bucket for a project
  • [ ] Warn users about potential costs if the temporary location is in a bucket with the soft delete policy enabled

Issue Priority

Priority: 2

Issue Components

  • [X] Component: Python SDK
  • [X] Component: Java SDK
  • [X] Component: Go SDK
  • [ ] Component: Typescript SDK
  • [ ] Component: IO connector
  • [ ] Component: Beam YAML
  • [ ] Component: Beam examples
  • [ ] Component: Beam playground
  • [ ] Component: Beam katas
  • [ ] Component: Website
  • [ ] Component: Spark Runner
  • [ ] Component: Flink Runner
  • [ ] Component: Samza Runner
  • [ ] Component: Twister2 Runner
  • [ ] Component: Hazelcast Jet Runner
  • [ ] Component: Google Cloud Dataflow Runner

shunping avatar May 17 '24 13:05 shunping

.take-issue

shunping avatar May 17 '24 13:05 shunping

What is the status here?

kennknowles avatar Jun 07 '24 18:06 kennknowles

Everything is done, except for adding a warning to Python SDK if the bucket has soft delete enabled.

shunping avatar Jun 07 '24 18:06 shunping

I am asking because it is targeting 2.57.0 release. Are we able to cherry-pick? Or is it good enough having some functionality on 2.57.0 branch?

kennknowles avatar Jun 10 '24 15:06 kennknowles

The three merged commits should be good for cherry-picking. I am waiting for the fourth(last) one to be reviewed. If it can get through today or tomorrow, can we cherry pick it as well?

shunping avatar Jun 10 '24 16:06 shunping

Ok. the remaining task is done and merged. I think we are good to close this issue @kennknowles.

shunping avatar Jun 10 '24 19:06 shunping

SGTM

kennknowles avatar Jun 11 '24 13:06 kennknowles