beam icon indicating copy to clipboard operation
beam copied to clipboard

start/close streams in parallel on new worker metadata

Open m-trieu opened this issue 1 year ago • 2 comments

Previously, StreamingEngineClient would start and close streams after getting new worker metadata synchronously (close 1 stream at time, open 1 stream at a time).

Make this happen in parallel and run async only blocking when needed.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

m-trieu avatar May 17 '24 00:05 m-trieu

R: @scwhittle

m-trieu avatar May 17 '24 00:05 m-trieu

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar May 17 '24 00:05 github-actions[bot]

Hey @m-trieu, can you resolve some of the merge conflicts then tag Sam again?

ahmedabu98 avatar Jun 26 '24 17:06 ahmedabu98