remove processing/scheduling logic from StreamingDataflowWorker
includes https://github.com/apache/beam/pull/31148
StreamingDataflowWorker will eventually just be constructing the harness runtime (different implementations for appliance, dispatched, fanout etc) and the main method.
R: @scwhittle
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @chamikaramj added as fallback since no labels match configuration
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
test failure is unrelated @scwhittle
I think the examples failure is unrelated so don't bother investigating it.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.51%. Comparing base (
5c30b1d) to head (8da5f40). Report is 42 commits behind head on master.
:exclamation: Current head 8da5f40 differs from pull request most recent head 570c4ef
Please upload reports for the commit 570c4ef to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #31317 +/- ##
============================================
- Coverage 68.55% 68.51% -0.05%
+ Complexity 14921 14823 -98
============================================
Files 2636 2636
Lines 222080 221689 -391
Branches 11825 11784 -41
============================================
- Hits 152238 151881 -357
+ Misses 63647 63629 -18
+ Partials 6195 6179 -16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
run java precommit
Run Java PreCommit