beam icon indicating copy to clipboard operation
beam copied to clipboard

add support for ConnectionFactory ProviderFn in JmsIO

Open tilgalas opened this issue 1 year ago • 3 comments

addresses #18110

Added a new configuration method withConnectionFactoryProviderFn to the JmsIO's Read and Write transforms, which enables the user to specify a lazily instantiated CF objects in case they're not serializable


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

tilgalas avatar May 13 '24 14:05 tilgalas

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 13 '24 15:05 github-actions[bot]

Reminder, please take a look at this pr: @damondouglas @shunping

github-actions[bot] avatar May 24 '24 12:05 github-actions[bot]

waiting on author

Abacn avatar May 24 '24 18:05 Abacn

Run Java_Examples_Dataflow PreCommit

tilgalas avatar May 29 '24 10:05 tilgalas

Run Java_Examples_Dataflow PreCommit

tilgalas avatar Jun 03 '24 10:06 tilgalas

Java Examples Dataflow PreCommit currently failing on master branch: #31421 not related to the change

Abacn avatar Jun 03 '24 13:06 Abacn