beam icon indicating copy to clipboard operation
beam copied to clipboard
verified publisher icon apache

clean up some grpc error handling for windmill streams

Open m-trieu opened this issue 1 year ago • 5 comments

Clean up some of the windmill stream error and stream handling

R: @arunpandianp

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

m-trieu avatar May 09 '24 22:05 m-trieu

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar May 09 '24 23:05 github-actions[bot]

failure is unrelated

assign set of reviewers

m-trieu avatar May 15 '24 00:05 m-trieu

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 15 '24 00:05 github-actions[bot]

if you put:

R: @arunpandianp in a comment instead of a PR description, bot shouldn't be confused.

tvalentyn avatar May 15 '24 15:05 tvalentyn

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar May 15 '24 15:05 github-actions[bot]

Hey @arunpandianp, have you had a chance to review this PR?

ahmedabu98 avatar Jun 26 '24 17:06 ahmedabu98