beam icon indicating copy to clipboard operation
beam copied to clipboard

Logging loading filesystems failures.

Open RyuSA opened this issue 1 year ago • 3 comments

Please add a meaningful description for your change here

fixes #31218

This PR contains these changes;

  • Added a new error handling for ModuleNotFoundError
    • no logging
  • Changed the error handling for ImportError
    • logging warn log with the exception to identify any issues around import.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

RyuSA avatar May 08 '24 14:05 RyuSA

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python. R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 08 '24 15:05 github-actions[bot]

Thanks, @RyuSA ! @Abacn had some suggestions about the proposal, so passing to @Abacn for review. Re formatter & lint errors: see: s.apache.org/beam-python-dev-wiki for pointers on linters and yapf. You can find information about error logs by clicking "Details".

tvalentyn avatar May 08 '24 20:05 tvalentyn

Reminder, please take a look at this pr: @tvalentyn @chamikaramj

github-actions[bot] avatar May 17 '24 12:05 github-actions[bot]