beam
beam copied to clipboard
apache
Set backlog in gauge metric for Kafka Reader
There are gauges created for per partition backlog in the kafka reader, but its never actually set.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @Abacn for label java. R: @Abacn for label io.
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
I vaguely remembered @johnjcasey mentioned before that there were some problem in gauge metrics, @johnjcasey do you have insight here?
Yeah, unfortunately Gauges work in Beam, but are not implemented in Dataflow properly. @celeste-zeng might have more up to date information here
Its still worth setting it in beam so if Dataflow implements Gauges the results will be piped through