beam icon indicating copy to clipboard operation
beam copied to clipboard

Export gcs options

Open Naireen opened this issue 11 months ago • 19 comments

Allow Customers to pass GIB.WSK parameters for the write File transform.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Naireen avatar Mar 27 '24 18:03 Naireen

Run Java PreCommit

Naireen avatar Mar 28 '24 06:03 Naireen

Run Java_IOs_Direct PreCommit

Naireen avatar Mar 28 '24 06:03 Naireen

Run Java PreCommit

Naireen avatar Mar 28 '24 20:03 Naireen

Run Java_IOs_Direct PreCommit

Naireen avatar Mar 28 '24 20:03 Naireen

Run Java PreCommit

Naireen avatar Mar 29 '24 11:03 Naireen

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.85%. Comparing base (2f8854a) to head (91ffa17). Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #30772      +/-   ##
============================================
- Coverage     71.47%   70.85%   -0.62%     
- Complexity        0     2983    +2983     
============================================
  Files           710     1062     +352     
  Lines        104815   132683   +27868     
  Branches          0     3230    +3230     
============================================
+ Hits          74915    94012   +19097     
- Misses        28268    35576    +7308     
- Partials       1632     3095    +1463     
Flag Coverage Δ
java 68.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 29 '24 13:03 codecov[bot]

Run Java_IOs_Direct PreCommit

Naireen avatar Mar 29 '24 19:03 Naireen

Run Java_IOs_Direct PreCommit

Naireen avatar Mar 29 '24 20:03 Naireen

Test seems flaky, will try rerunning again:

Naireen avatar Mar 29 '24 21:03 Naireen

Run Java_IOs_Direct PreCommit

Naireen avatar Mar 29 '24 21:03 Naireen

Checks are passing, the one failing is for parsing test results (saying the file is too large: https://github.com/apache/beam/pull/30772/checks?check_run_id=23251024301)

Naireen avatar Apr 01 '24 17:04 Naireen

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Apr 01 '24 17:04 github-actions[bot]

assign set of reviewers

Naireen avatar Apr 02 '24 16:04 Naireen

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @bvolpato for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Apr 02 '24 16:04 github-actions[bot]

Reminder, please take a look at this pr: @bvolpato

github-actions[bot] avatar Apr 10 '24 12:04 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.85%. Comparing base (2f8854a) to head (91ffa17). Report is 216 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #30772      +/-   ##
============================================
- Coverage     71.47%   70.85%   -0.62%     
- Complexity        0     2983    +2983     
============================================
  Files           710     1062     +352     
  Lines        104815   132683   +27868     
  Branches          0     3230    +3230     
============================================
+ Hits          74915    94012   +19097     
- Misses        28268    35576    +7308     
- Partials       1632     3095    +1463     
Flag Coverage Δ
java 68.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 10 '24 12:04 codecov-commenter

Reminder, please take a look at this pr: @bvolpato

github-actions[bot] avatar Apr 18 '24 12:04 github-actions[bot]

R: @scwhittle

Naireen avatar Apr 18 '24 16:04 Naireen

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Apr 18 '24 16:04 github-actions[bot]

@Naireen Friendly ping, is this still relevant?

scwhittle avatar Jun 13 '24 10:06 scwhittle

@Naireen Friendly ping, is this still relevant?

Yes this is, sorry this fell through the cracks, will address your comments and rebase this PR sometimes next week.

Naireen avatar Jul 19 '24 18:07 Naireen

Actually, I see that https://github.com/apache/beam/pull/31617 went in last month, so I'm going to close this!

Naireen avatar Jul 22 '24 15:07 Naireen