beam
beam copied to clipboard
Export gcs options
Allow Customers to pass GIB.WSK parameters for the write File transform.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead. - [ ] Update
CHANGES.md
with noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Run Java PreCommit
Run Java_IOs_Direct PreCommit
Run Java PreCommit
Run Java_IOs_Direct PreCommit
Run Java PreCommit
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.85%. Comparing base (
2f8854a
) to head (91ffa17
). Report is 11 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #30772 +/- ##
============================================
- Coverage 71.47% 70.85% -0.62%
- Complexity 0 2983 +2983
============================================
Files 710 1062 +352
Lines 104815 132683 +27868
Branches 0 3230 +3230
============================================
+ Hits 74915 94012 +19097
- Misses 28268 35576 +7308
- Partials 1632 3095 +1463
Flag | Coverage Δ | |
---|---|---|
java | 68.52% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Run Java_IOs_Direct PreCommit
Run Java_IOs_Direct PreCommit
Test seems flaky, will try rerunning again:
Run Java_IOs_Direct PreCommit
Checks are passing, the one failing is for parsing test results (saying the file is too large: https://github.com/apache/beam/pull/30772/checks?check_run_id=23251024301)
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
assign set of reviewers
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer
:
R: @bvolpato for label java.
Available commands:
-
stop reviewer notifications
- opt out of the automated review tooling -
remind me after tests pass
- tag the comment author after tests pass -
waiting on author
- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Reminder, please take a look at this pr: @bvolpato
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.85%. Comparing base (
2f8854a
) to head (91ffa17
). Report is 216 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #30772 +/- ##
============================================
- Coverage 71.47% 70.85% -0.62%
- Complexity 0 2983 +2983
============================================
Files 710 1062 +352
Lines 104815 132683 +27868
Branches 0 3230 +3230
============================================
+ Hits 74915 94012 +19097
- Misses 28268 35576 +7308
- Partials 1632 3095 +1463
Flag | Coverage Δ | |
---|---|---|
java | 68.52% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reminder, please take a look at this pr: @bvolpato
R: @scwhittle
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
@Naireen Friendly ping, is this still relevant?
@Naireen Friendly ping, is this still relevant?
Yes this is, sorry this fell through the cracks, will address your comments and rebase this PR sometimes next week.
Actually, I see that https://github.com/apache/beam/pull/31617 went in last month, so I'm going to close this!