Add direct path code path
Add direct path code path
we will be able to run direct path pipelines by passing in the option is IsWindmillServiceDirectPathEnabled
- I added some new components (they are just encapsulated existing logic from StreamingDataflowWorker.java) and will back port this to
StreamingDataflowWorkerin a seperate pr - the pr that added the channel caches were rolled back, am working on reintegrating that
R: @scwhittle
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
@scwhittle still wrapping up the unit tests, just would like an initial pass thanks!
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @Abacn added as fallback since no labels match configuration
Available commands:
stop reviewer notifications- opt out of the automated review toolingremind me after tests pass- tag the comment author after tests passwaiting on author- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.27%. Comparing base (
96dc16a) to head (ec12c72). Report is 234 commits behind head on master.
:exclamation: Current head ec12c72 differs from pull request most recent head e60cb1e. Consider uploading reports for the commit e60cb1e to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #30764 +/- ##
============================================
+ Coverage 70.95% 71.27% +0.32%
+ Complexity 4470 1485 -2985
============================================
Files 1257 904 -353
Lines 140917 112898 -28019
Branches 4305 1076 -3229
============================================
- Hits 99989 80471 -19518
+ Misses 37451 30408 -7043
+ Partials 3477 2019 -1458
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reminder, please take a look at this pr: @Abacn
@Abacn not sure how to turn off the reminders but this doesn't require a look. It is being broken apart into smaller PRs which I am reviewing.
@m-trieu Should we close this one for now? We can reopen after rebasing on top of the broken off PRs
Reminder, please take a look at this pr: @Abacn