beam icon indicating copy to clipboard operation
beam copied to clipboard

Allow JSON type in TableSchema for WriteToBigQuery with FILE_LOAD method in Python SDK

Open sapphire008 opened this issue 1 year ago • 1 comments

Removing the JSON type check when using WriteToBigQuery with FILE_LOAD method in Python SDK. Throwing a warning instead.

  • Related to the change in Java SDK: https://github.com/apache/beam/pull/29923. Consistent with this PR for Java SDK, I have changed the raise ValueError to a logging.warn`.
  • Relevant lines of code https://github.com/apache/beam/blob/8a74a1c279c86a262def9b99418e7eb03366e2d9/sdks/python/apache_beam/io/gcp/bigquery.py#L2178-L2191

I did some hackish testing against a table of my own and it was able to insert the json fields correctly without a problem.

NOT RECOMMENDED but it solves the problem for those who need this tomorrow:

In my docker file that has Apache Beam installed, I used sed to replace the check:

RUN sed -i 's/if field\['\''type'\''\] == '\''JSON'\'':/if field\['\''type'\''\] == '\''JSON_IS_OKAY'\'':/g' /usr/local/lib/python3.11/site-packages/apache_beam/io/gcp/bigquery.py


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

sapphire008 avatar Feb 18 '24 05:02 sapphire008

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Feb 18 '24 07:02 github-actions[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python. R: @bvolpato for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Feb 19 '24 00:02 github-actions[bot]