beam icon indicating copy to clipboard operation
beam copied to clipboard

Throw RuntimeException with the resource id when IOException happens in FileBasedSource

Open liferoad opened this issue 1 year ago • 1 comments

Throwing the error that contains the resource id could help users identify which file could cause issues.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

liferoad avatar Feb 16 '24 20:02 liferoad

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Feb 16 '24 21:02 github-actions[bot]

Failing tests

  • testFhirIO_Import[STU3] in GCP_IO precommit
  • testThreadsAreAddedOnlyAsNeededWithContention
  • RemoteExecutionTest.testSplit

most likely unrelated flaky. Rerunning..

Abacn avatar Feb 20 '24 18:02 Abacn