beam icon indicating copy to clipboard operation
beam copied to clipboard

Implement ordered list state for FnApi.

Open shunping opened this issue 1 year ago • 12 comments

First attempt to implement ordered list state for FnApi. Notice that caching has not been implemented yet.

Reference: https://docs.google.com/document/d/1U77sAvE6Iy9XsVruRYHxPdFji7nqS6HPi1XU8fhyrxs/


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

shunping avatar Feb 14 '24 20:02 shunping

Run Python PreCommit 3.9

shunping avatar Feb 15 '24 16:02 shunping

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Mar 06 '24 17:03 github-actions[bot]

Run Java PreCommit

shunping avatar Mar 06 '24 20:03 shunping

Reminder, please take a look at this pr: @robertwb

github-actions[bot] avatar Mar 14 '24 12:03 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Mar 22 '24 12:03 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles

github-actions[bot] avatar Mar 29 '24 12:03 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Apr 03 '24 12:04 github-actions[bot]

waiting on author

Abacn avatar Apr 03 '24 14:04 Abacn

Reminder, please take a look at this pr: @Abacn

github-actions[bot] avatar May 11 '24 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 15 '24 12:05 github-actions[bot]

stop reviewer notifications

shunping avatar May 15 '24 13:05 shunping

Stopping reviewer notifications for this pull request: requested by reviewer

github-actions[bot] avatar May 15 '24 13:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.13%. Comparing base (8a64641) to head (b481880). Report is 1 commits behind head on master.

:exclamation: Current head b481880 differs from pull request most recent head f4c3440

Please upload reports for the commit f4c3440 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #30317      +/-   ##
============================================
- Coverage     71.18%   71.13%   -0.06%     
  Complexity     3014     3014              
============================================
  Files          1058     1055       -3     
  Lines        134076   133466     -610     
  Branches       3254     3254              
============================================
- Hits          95437    94935     -502     
+ Misses        35498    35400      -98     
+ Partials       3141     3131      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 11 '24 20:06 codecov[bot]

Run Java PreCommit

shunping avatar Jun 12 '24 13:06 shunping

Run Java_IOs_Direct PreCommit

shunping avatar Jun 12 '24 13:06 shunping

Run Go PreCommit

shunping avatar Jun 13 '24 03:06 shunping