beam icon indicating copy to clipboard operation
beam copied to clipboard

Debug prebuilt container workflow

Open damccorm opened this issue 1 year ago • 1 comments

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

damccorm avatar Feb 13 '24 14:02 damccorm

The current failure is that it fails to delete some images, because those images were referred to other images. However, on the second one those images can get deleted (as the one that refers it get deleted now), and there is no leak. Probably just remove the last check.

Abacn avatar Feb 14 '24 17:02 Abacn

Probably just remove the last check.

I think keeping the check is still worthwhile because if there's an issue stale containers could pile up. I went with a slightly different approach: allow some containers to be skipped, but only up to 10. It worked in https://github.com/apache/beam/actions/runs/7992925962 and I think should generally work

damccorm avatar Feb 21 '24 18:02 damccorm

R: @Abacn

damccorm avatar Feb 21 '24 18:02 damccorm

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Feb 21 '24 19:02 github-actions[bot]