beam icon indicating copy to clipboard operation
beam copied to clipboard

Schema field number documentation

Open bzablocki opened this issue 1 year ago • 2 comments

As reported in #30273, the documentation of the SchemaFieldNumber annotation has an error. This PR fixes this error.

Cheers,

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

bzablocki avatar Feb 09 '24 13:02 bzablocki

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Feb 09 '24 14:02 github-actions[bot]

Unfortunately it seems like it'd be backwards incompatible to actually make it take an int, right?

Yes, I can't think of an elegant way to make a backwards compatible version of this annotation that takes an int.

bzablocki avatar Feb 13 '24 11:02 bzablocki

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Apr 13 '24 12:04 github-actions[bot]

Hi @robertwb, I believe the failing tests are just flaky - could you rerun the tests? Can we merge if they pass?

bzablocki avatar Apr 18 '24 10:04 bzablocki