beam icon indicating copy to clipboard operation
beam copied to clipboard

Clean up stale code in BigtableService

Open mutianf opened this issue 1 year ago • 23 comments

The underlying issue with attempt timeout is fixed in the Bigtable client. We don't need to pass around operation and attempt timeout in the reader anymore. This PR cleans up the code that's not used anymore.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

mutianf avatar Jan 31 '24 20:01 mutianf

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @bvolpato for label java. R: @chamikaramj for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Jan 31 '24 22:01 github-actions[bot]

Are these "stale code" not used in Beam, i.e., there is currently no way to make this code in effect; or it's not needed? If it still can make some effect on Beam I would suggests defer the clean up until we see the issue no longer exist for a time period

Abacn avatar Feb 01 '24 18:02 Abacn

Reminder, please take a look at this pr: @bvolpato @chamikaramj @igorbernstein2

github-actions[bot] avatar Feb 09 '24 12:02 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java. R: @damondouglas for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Feb 13 '24 12:02 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles @damondouglas @igorbernstein2

github-actions[bot] avatar Feb 21 '24 12:02 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @chamikaramj for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Feb 26 '24 12:02 github-actions[bot]

Reminder, please take a look at this pr: @Abacn @chamikaramj @igorbernstein2

github-actions[bot] avatar Mar 04 '24 12:03 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java. R: @johnjcasey for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Mar 07 '24 12:03 github-actions[bot]

@mutianf I'll have a look at it. Apologies for your wait.

damondouglas avatar Mar 07 '24 17:03 damondouglas

Reminder, please take a look at this pr: @damondouglas @johnjcasey @igorbernstein2

github-actions[bot] avatar Mar 15 '24 12:03 github-actions[bot]

@mutianf LGTM, would you like me to merge this?

damondouglas avatar Mar 16 '24 03:03 damondouglas

Reminder, please take a look at this pr: @damondouglas @johnjcasey @igorbernstein2

github-actions[bot] avatar Mar 23 '24 12:03 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java. R: @chamikaramj for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Mar 27 '24 12:03 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles @chamikaramj @igorbernstein2

github-actions[bot] avatar Apr 04 '24 12:04 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @Abacn for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Apr 09 '24 12:04 github-actions[bot]

Reminder, please take a look at this pr: @robertwb @Abacn @igorbernstein2

github-actions[bot] avatar Apr 17 '24 12:04 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java. R: @damondouglas for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Apr 19 '24 12:04 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles @damondouglas @igorbernstein2

github-actions[bot] avatar Apr 27 '24 12:04 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java. R: @ahmedabu98 for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 01 '24 12:05 github-actions[bot]

Reminder, please take a look at this pr: @robertwb @ahmedabu98 @igorbernstein2

github-actions[bot] avatar May 08 '24 12:05 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java. R: @Abacn for label io. R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar May 12 '24 12:05 github-actions[bot]

This one has taken long. Going to merge it in 24 hrs if no other concern

Abacn avatar May 15 '24 15:05 Abacn

Reminder, please take a look at this pr: @Abacn @Abacn @igorbernstein2

github-actions[bot] avatar May 23 '24 12:05 github-actions[bot]