beam icon indicating copy to clipboard operation
beam copied to clipboard

Replace StorageV1 client with GCS client - Draft

Open BjornPrime opened this issue 2 years ago • 13 comments

Addresses #25676.

Draft PR to maintain commit history.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

BjornPrime avatar Sep 29 '23 02:09 BjornPrime

Codecov Report

Attention: Patch coverage is 6.91489% with 175 lines in your changes are missing coverage. Please review.

Project coverage is 37.90%. Comparing base (d32a8e5) to head (20513f9). Report is 1026 commits behind head on master.

Files Patch % Lines
sdks/python/apache_beam/io/gcp/gcsio.py 9.60% 113 Missing :warning:
...apache_beam/runners/dataflow/internal/apiclient.py 0.00% 23 Missing :warning:
..._beam/runners/portability/sdk_container_builder.py 0.00% 15 Missing :warning:
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 0.00% 13 Missing :warning:
...ks/python/apache_beam/runners/interactive/utils.py 0.00% 10 Missing :warning:
sdks/python/apache_beam/internal/gcp/auth.py 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28733      +/-   ##
==========================================
- Coverage   38.40%   37.90%   -0.50%     
==========================================
  Files         686      683       -3     
  Lines      101629   100677     -952     
==========================================
- Hits        39029    38163     -866     
+ Misses      61017    60931      -86     
  Partials     1583     1583              
Flag Coverage Δ
python 29.10% <6.91%> (-0.91%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '23 13:10 codecov[bot]

Run Python 3.11 PostCommit

BjornPrime avatar Oct 26 '23 16:10 BjornPrime

Run Python 3.11 PostCommit

BjornPrime avatar Oct 26 '23 17:10 BjornPrime

Run Python 3.11 PostCommit

BjornPrime avatar Oct 26 '23 19:10 BjornPrime

Run Python 3.11 PostCommit

BjornPrime avatar Oct 26 '23 19:10 BjornPrime

Run Python 3.11 PostCommit

BjornPrime avatar Oct 27 '23 16:10 BjornPrime

Run Python 3.11 PostCommit

BjornPrime avatar Oct 30 '23 14:10 BjornPrime

Run Python 3.11 PostCommit

BjornPrime avatar Oct 30 '23 17:10 BjornPrime

Run Python 3.11 PostCommit

BjornPrime avatar Oct 30 '23 21:10 BjornPrime

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 30 '23 12:12 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Mar 01 '24 12:03 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar May 01 '24 12:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 6.91489% with 175 lines in your changes missing coverage. Please review.

Project coverage is 37.90%. Comparing base (d32a8e5) to head (20513f9). Report is 2317 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/io/gcp/gcsio.py 9.60% 113 Missing :warning:
...apache_beam/runners/dataflow/internal/apiclient.py 0.00% 23 Missing :warning:
..._beam/runners/portability/sdk_container_builder.py 0.00% 15 Missing :warning:
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 0.00% 13 Missing :warning:
...ks/python/apache_beam/runners/interactive/utils.py 0.00% 10 Missing :warning:
sdks/python/apache_beam/internal/gcp/auth.py 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28733      +/-   ##
==========================================
- Coverage   38.40%   37.90%   -0.50%     
==========================================
  Files         686      683       -3     
  Lines      101629   100677     -952     
==========================================
- Hits        39029    38163     -866     
+ Misses      61017    60931      -86     
  Partials     1583     1583              
Flag Coverage Δ
python 29.10% <6.91%> (-0.91%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 01 '24 12:05 codecov-commenter

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jul 01 '24 12:07 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Aug 31 '24 12:08 github-actions[bot]