beam
beam copied to clipboard
[yaml] Add yaml_provider.py Unit Tests
Add unit tests for yaml_provider.py.
This PR also introduces non-breaking name changes to functions and variables to suppress IDE warnings.
There is also a change to the WithSchema
built-in transform - it now requires a schema
tag so that the schema field names do not collide with the top-level transform tags (e.g "name").
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead. - [x] Update
CHANGES.md
with noteworthy changes. - [x] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Codecov Report
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
1032533
) 72.31% compared to head (6eea11a
) 72.34%. Report is 1245 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
sdks/python/apache_beam/yaml/yaml_provider.py | 72.72% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #27804 +/- ##
==========================================
+ Coverage 72.31% 72.34% +0.03%
==========================================
Files 683 683
Lines 100633 100640 +7
==========================================
+ Hits 72768 72813 +45
+ Misses 26289 26251 -38
Partials 1576 1576
Flag | Coverage Δ | |
---|---|---|
python | 82.88% <72.72%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer
:
R: @liferoad for label python.
Available commands:
-
stop reviewer notifications
- opt out of the automated review tooling -
remind me after tests pass
- tag the comment author after tests pass -
waiting on author
- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Reminder, please take a look at this pr: @liferoad
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer
:
R: @AnandInguva for label python.
Available commands:
-
stop reviewer notifications
- opt out of the automated review tooling -
remind me after tests pass
- tag the comment author after tests pass -
waiting on author
- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
Reminder, please take a look at this pr: @AnandInguva
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
@Polber is this PR still relevant?
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
Codecov Report
Attention: Patch coverage is 72.72727%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 72.34%. Comparing base (
1032533
) to head (6eea11a
). Report is 2582 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
sdks/python/apache_beam/yaml/yaml_provider.py | 72.72% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #27804 +/- ##
==========================================
+ Coverage 72.31% 72.34% +0.03%
==========================================
Files 683 683
Lines 100633 100640 +7
==========================================
+ Hits 72768 72813 +45
+ Misses 26289 26251 -38
Partials 1576 1576
Flag | Coverage Δ | |
---|---|---|
python | 82.88% <72.72%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.