beam icon indicating copy to clipboard operation
beam copied to clipboard

GA migration and sharding Python Postcommit ML

Open benEng opened this issue 3 years ago • 2 comments

As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:

The migrated workflow was added to CI.md

DO NOT MERGE until the effort to use self-hosted runners is completed https://github.com/apache/beam/pull/22703


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

benEng avatar Sep 20 '22 21:09 benEng

Successful execution on self-hosted runners:

https://github.com/benWize/beam/actions/runs/3084368879

benEng avatar Sep 20 '22 21:09 benEng

Codecov Report

Merging #23312 (6169840) into master (4c3750d) will increase coverage by 0.55%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23312      +/-   ##
==========================================
+ Coverage   73.36%   73.91%   +0.55%     
==========================================
  Files         719      737      +18     
  Lines       97137   104305    +7168     
==========================================
+ Hits        71260    77098    +5838     
- Misses      24530    25896    +1366     
+ Partials     1347     1311      -36     
Flag Coverage Δ
python 82.75% <ø> (-0.24%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/metrics/dumper.go 0.00% <0.00%> (-53.97%) :arrow_down:
sdks/go/pkg/beam/core/metrics/store.go 10.63% <0.00%> (-25.54%) :arrow_down:
sdks/go/pkg/beam/runners/direct/gbk.go 72.35% <0.00%> (-11.24%) :arrow_down:
sdks/go/pkg/beam/core/metrics/metrics.go 49.36% <0.00%> (-10.93%) :arrow_down:
sdks/python/apache_beam/utils/python_callable.py 90.32% <0.00%> (-7.72%) :arrow_down:
sdks/go/pkg/beam/core/typex/fulltype.go 41.50% <0.00%> (-7.33%) :arrow_down:
sdks/go/pkg/beam/register/emitter.go 47.69% <0.00%> (-6.37%) :arrow_down:
sdks/go/pkg/beam/core/runtime/exec/window.go 49.01% <0.00%> (-5.99%) :arrow_down:
sdks/go/pkg/beam/options/jobopts/options.go 87.27% <0.00%> (-5.91%) :arrow_down:
sdks/go/pkg/beam/register/iter.go 67.21% <0.00%> (-5.76%) :arrow_down:
... and 124 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 20 '22 21:09 codecov[bot]

LGTM!

fernando-wizeline avatar Sep 21 '22 21:09 fernando-wizeline

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python. R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Sep 23 '22 17:09 github-actions[bot]

is this ready for review? who should review this?

pabloem avatar Sep 30 '22 06:09 pabloem

is this ready for review? who should review this?

Hi @pabloem, it is ready for review but the merge should wait until the self-hosted runners are ready. @damccorm could be the reviewer, he has more context on this effort!

benEng avatar Sep 30 '22 15:09 benEng

Reminder, please take a look at this pr: @pabloem @damccorm

github-actions[bot] avatar Oct 14 '22 12:10 github-actions[bot]

Left one more comment. apart from that, LGTM

AnandInguva avatar Oct 14 '22 16:10 AnandInguva

Reminder, please take a look at this pr: @pabloem @damccorm

github-actions[bot] avatar Dec 21 '22 12:12 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python. R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Dec 26 '22 12:12 github-actions[bot]

stop reviewer notifications

damccorm avatar Dec 27 '22 11:12 damccorm

Stopping reviewer notifications for this pull request: requested by reviewer

github-actions[bot] avatar Dec 27 '22 11:12 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Feb 27 '23 12:02 github-actions[bot]