beam icon indicating copy to clipboard operation
beam copied to clipboard

[CdapIO] Add integration tests for SparkReceiverIO

Open Amar3tto opened this issue 2 years ago • 3 comments

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

Amar3tto avatar Sep 20 '22 14:09 Amar3tto

Codecov Report

Merging #23305 (a0ad7c7) into master (96051f2) will decrease coverage by 0.19%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #23305      +/-   ##
==========================================
- Coverage   73.19%   72.99%   -0.20%     
==========================================
  Files         720      729       +9     
  Lines       96069    96720     +651     
==========================================
+ Hits        70313    70598     +285     
- Misses      24444    24810     +366     
  Partials     1312     1312              
Flag Coverage Δ
python 82.58% <0.00%> (-0.38%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dks/python/apache_beam/options/pipeline_options.py 94.45% <ø> (ø)
...on/apache_beam/runners/portability/spark_runner.py 67.34% <0.00%> (ø)
...m/runners/portability/spark_uber_jar_job_server.py 84.32% <0.00%> (ø)
sdks/python/apache_beam/typehints/__init__.py 71.42% <0.00%> (-6.35%) :arrow_down:
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) :arrow_down:
sdks/python/apache_beam/typehints/schemas.py 88.95% <0.00%> (-2.98%) :arrow_down:
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) :arrow_down:
...teractive/testing/integration/notebook_executor.py 28.86% <0.00%> (-1.04%) :arrow_down:
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) :arrow_down:
sdks/python/apache_beam/coders/coder_impl.py 93.77% <0.00%> (-0.17%) :arrow_down:
... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 20 '22 15:09 codecov[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @apilloud for label java. R: @Abacn for label build. R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Sep 20 '22 15:09 github-actions[bot]

Run Python PreCommit

elizaveta-lomteva avatar Sep 21 '22 15:09 elizaveta-lomteva

@chamikaramj @aromanenko-dev Integration tests for SparkReceiverIO PR is ready for review Thank you!

elizaveta-lomteva avatar Sep 22 '22 15:09 elizaveta-lomteva

@Lizzfox Thanks, I'll take a look

aromanenko-dev avatar Sep 23 '22 14:09 aromanenko-dev

Run Seed Job

aromanenko-dev avatar Oct 04 '22 16:10 aromanenko-dev

Run Seed Job

aromanenko-dev avatar Oct 06 '22 14:10 aromanenko-dev

Run Python PreCommit

Amar3tto avatar Oct 07 '22 07:10 Amar3tto

Run Seed Job

aromanenko-dev avatar Oct 13 '22 15:10 aromanenko-dev

Retest this please

aromanenko-dev avatar Oct 14 '22 08:10 aromanenko-dev

Run Seed Job

aromanenko-dev avatar Oct 17 '22 13:10 aromanenko-dev

Run Java SparkReceiverIO Performance Test

aromanenko-dev avatar Oct 17 '22 14:10 aromanenko-dev

Retest this please

Amar3tto avatar Oct 18 '22 05:10 Amar3tto

Run Java_Kafka_IO_Direct PreCommit

elizaveta-lomteva avatar Oct 18 '22 07:10 elizaveta-lomteva

Run Java_Examples_Dataflow PreCommit

elizaveta-lomteva avatar Oct 18 '22 07:10 elizaveta-lomteva

Run Java PreCommit

elizaveta-lomteva avatar Oct 18 '22 07:10 elizaveta-lomteva

Run Go PreCommit

elizaveta-lomteva avatar Oct 18 '22 07:10 elizaveta-lomteva

Run Java SparkReceiverIO Performance Test

elizaveta-lomteva avatar Oct 18 '22 07:10 elizaveta-lomteva

Run Java SparkReceiverIO Performance Test

aromanenko-dev avatar Oct 18 '22 08:10 aromanenko-dev

Run Java SparkReceiverIO Performance Test

aromanenko-dev avatar Oct 18 '22 11:10 aromanenko-dev

Run Java PreCommit

aromanenko-dev avatar Oct 18 '22 11:10 aromanenko-dev

Run Java_Spark3_Versions PreCommit

aromanenko-dev avatar Oct 18 '22 11:10 aromanenko-dev

Run Python_PVR_Flink PreCommit

aromanenko-dev avatar Oct 18 '22 11:10 aromanenko-dev

Unfortunately, the job SparkReceiverIO Performance Test is still failing.

aromanenko-dev avatar Oct 18 '22 14:10 aromanenko-dev

@aromanenko-dev the .groovy file has been modified, so the Seed Job must be run first Thanks

elizaveta-lomteva avatar Oct 19 '22 11:10 elizaveta-lomteva

Run Java SparkReceiverIO Performance Test

aromanenko-dev avatar Oct 19 '22 12:10 aromanenko-dev

Run Java_Debezium_IO_Direct PreCommit

elizaveta-lomteva avatar Oct 19 '22 16:10 elizaveta-lomteva

Run Java SparkReceiverIO Performance Test

aromanenko-dev avatar Oct 20 '22 08:10 aromanenko-dev

Run Java SparkReceiverIO Performance Test

aromanenko-dev avatar Oct 26 '22 14:10 aromanenko-dev

Run Java SparkReceiverIO Performance Test

aromanenko-dev avatar Oct 27 '22 11:10 aromanenko-dev