beam icon indicating copy to clipboard operation
beam copied to clipboard

GA Migration Python Precommit IOs

Open benEng opened this issue 3 years ago • 2 comments

As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:

The migrated workflows were added to CI.md

DO NOT MERGE until the effort to use self-hosted runners is completed https://github.com/apache/beam/pull/22703 These workflows use base actions listed in https://github.com/apache/beam/pull/23109 (Dependency)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

benEng avatar Sep 14 '22 22:09 benEng

Successful executions on self-hosted runners:

  • Avro https://github.com/benWize/beam/actions/runs/3055850770
  • Azure https://github.com/benWize/beam/actions/runs/3055850702
  • Flink https://github.com/benWize/beam/actions/runs/3055850703
  • GCP https://github.com/benWize/beam/actions/runs/3055850701
  • ML https://github.com/benWize/beam/actions/runs/3055850699

benEng avatar Sep 14 '22 22:09 benEng

Codecov Report

Merging #23241 (9264df4) into master (61e2ec1) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23241      +/-   ##
==========================================
+ Coverage   73.34%   73.35%   +0.01%     
==========================================
  Files         719      712       -7     
  Lines       97134    96243     -891     
==========================================
- Hits        71244    70601     -643     
+ Misses      24541    24331     -210     
+ Partials     1349     1311      -38     
Flag Coverage Δ
python 83.01% <ø> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/metrics/dumper.go 0.00% <0.00%> (-49.21%) :arrow_down:
sdks/go/pkg/beam/core/metrics/store.go 10.63% <0.00%> (-25.54%) :arrow_down:
sdks/go/pkg/beam/runners/direct/gbk.go 72.35% <0.00%> (-11.24%) :arrow_down:
sdks/go/pkg/beam/core/metrics/metrics.go 49.36% <0.00%> (-10.93%) :arrow_down:
sdks/go/pkg/beam/core/typex/fulltype.go 41.50% <0.00%> (-7.33%) :arrow_down:
sdks/go/pkg/beam/register/emitter.go 47.69% <0.00%> (-6.37%) :arrow_down:
sdks/go/pkg/beam/core/runtime/exec/window.go 49.01% <0.00%> (-5.99%) :arrow_down:
sdks/go/pkg/beam/options/jobopts/options.go 87.27% <0.00%> (-5.91%) :arrow_down:
sdks/go/pkg/beam/register/iter.go 67.21% <0.00%> (-5.76%) :arrow_down:
sdks/go/pkg/beam/core/runtime/exec/translate.go 12.72% <0.00%> (-4.48%) :arrow_down:
... and 51 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 14 '22 22:09 codecov[bot]

LGTM!

fernando-wizeline avatar Sep 21 '22 21:09 fernando-wizeline

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python. R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Sep 23 '22 17:09 github-actions[bot]

Thanks! This will really help the current huge (>1h) Python PreCommit test suite. Will look into it.

Abacn avatar Sep 23 '22 17:09 Abacn

Run Python_PVR_Flink PreCommit

benEng avatar Sep 27 '22 17:09 benEng

Run Python PreCommit

benEng avatar Sep 27 '22 17:09 benEng

Reminder, please take a look at this pr: @AnandInguva @Abacn

github-actions[bot] avatar Oct 08 '22 12:10 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python. R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Oct 12 '22 12:10 github-actions[bot]

LGTM, thanks!

Abacn avatar Oct 12 '22 14:10 Abacn

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Feb 12 '23 12:02 github-actions[bot]