beam icon indicating copy to clipboard operation
beam copied to clipboard

[Playground][Tour Of Beam] Datastore entities segregation

Open eantyshev opened this issue 2 years ago • 1 comments

Make separate Playground CI/CD steps for Playground and Tour Of Beam examples. For that, we introduce 2 command line parameters for ci_cd.py:

  • --dirs: a list of dirs to search for examples
  • --origin: PG_EXAMPLES or TB_EXAMPLES

Sample CI/CD run step:

export BEAM_ROOT_DIR=../../
export DIRS="learning/katas sdks examples"
python3 ci_cd.py --step CD --sdk SDK_JAVA --origin PG_EXAMPLES --dirs $DIRS

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

eantyshev avatar Sep 08 '22 14:09 eantyshev

Codecov Report

Merging #23088 (dc58a46) into master (2955954) will decrease coverage by 0.03%. The diff coverage is n/a.

:exclamation: Current head dc58a46 differs from pull request most recent head 03dcc63. Consider uploading reports for the commit 03dcc63 to get more accurate results

@@            Coverage Diff             @@
##           master   #23088      +/-   ##
==========================================
- Coverage   73.47%   73.43%   -0.04%     
==========================================
  Files         718      718              
  Lines       95878    95770     -108     
==========================================
- Hits        70443    70330     -113     
- Misses      24124    24129       +5     
  Partials     1311     1311              
Flag Coverage Δ
go 50.89% <0.00%> (ø)
python 83.19% <0.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/internal/gcp/auth.py 73.33% <0.00%> (-5.34%) :arrow_down:
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) :arrow_down:
...ks/python/apache_beam/runners/worker/data_plane.py 87.57% <0.00%> (-1.70%) :arrow_down:
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) :arrow_down:
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) :arrow_down:
...ython/apache_beam/io/gcp/bigquery_read_internal.py 57.21% <0.00%> (-0.49%) :arrow_down:
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) :arrow_down:
...eam/runners/interactive/interactive_environment.py 91.71% <0.00%> (-0.31%) :arrow_down:
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.25%) :arrow_down:
sdks/python/apache_beam/io/gcp/bigquery.py 74.03% <0.00%> (-0.21%) :arrow_down:
... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 21 '22 03:09 codecov[bot]

R: @pabloem

olehborysevych avatar Oct 05 '22 11:10 olehborysevych

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Oct 05 '22 11:10 github-actions[bot]

I've realized that we had a bug in Collect&Deploy Examples workflow https://github.com/apache/beam/blob/master/.github/workflows/playground_deploy_examples.yml#L50 It checks that there're affected examples only in the last commit of a PR which resulted in very rare examples deployments It is fixed in this PR but the production backend isn't up-to-date to compile some of the Go examples The deployments will start and break ~4 Go examples on production Conclusion: we need to update Playground backend (and maybe frontend) ASAP and only then merge this PR

eantyshev avatar Oct 10 '22 11:10 eantyshev

@damccorm @pabloem As there's currently a bug in Playground Examples CD which prevents its regular execution, we'll temporarily use manual trigger in workflow, to ensure that it doesn't break examples accidentally. Will be addressed in #23600 Ready for merge

eantyshev avatar Oct 12 '22 10:10 eantyshev

since Danny was already doing the review, I'll let him continue.

pabloem avatar Oct 12 '22 15:10 pabloem