GA Migration RAT Spotless Whitespace PreCommit

[fernando-wizeline]

As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:

Migrated workflow job-precommit-rat.yml Migrated workflow job-precommit-spotless.yml Migrated workflow job-precommit-whitespace.yml

The migrated workflow was removed from .test-infra/jenkins/README.md and added to CI.md

DO NOT MERGE until the effort to use self-hosted runners is completed https://github.com/apache/beam/pull/22703

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• [ ] Choose reviewer(s) and mention them in a comment (R: @username).
• [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• [ ] Update CHANGES.md with noteworthy changes.
• [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[codecov[bot]]

Codecov Report

Merging #23080 (01d49ba) into master (70f1c71) will increase coverage by 0.36%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23080      +/-   ##
==========================================
+ Coverage   73.58%   73.94%   +0.36%     
==========================================
  Files         716      716              
  Lines       95316    94319     -997     
==========================================
- Hits        70140    69746     -394     
+ Misses      23880    23287     -593     
+ Partials     1296     1286      -10     

Flag	Coverage Δ
python	83.42% <ø> (+0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[fernando-wizeline]

Hi @damccorm! We're facing a minor inconvenience regarding the checkstyle report created by the spotless task. In jenkins, that task creates a report like the following There are a couple of unofficial plugins that generate a really short status section within github, although not that different from the one already provided by github. My question is: would it be ok if we skip the report generation for the time being? Please let me know what you think about this. Thanks!

[damccorm]

My question is: would it be ok if we skip the report generation for the time being? Please let me know what you think about this.

What does the current experience look like when there is a violation? I'm fine not generating the report as long as there's a good way to figure out what violation caused a workflow to fail

[fernando-wizeline]

My question is: would it be ok if we skip the report generation for the time being? Please let me know what you think about this.

What does the current experience look like when there is a violation? I'm fine not generating the report as long as there's a good way to figure out what violation caused a workflow to fail

Hi Danny! Currently the errors are presented in the results window of the github job right at the end, with all the info as to why they failed the validation.

[damccorm]

Currently the errors are presented in the results window of the github job right at the end, with all the info as to why they failed the validation.

That sounds fine to me - depending on how good they are we might not need to come back to report generation at all. Any chance you could share a screenshot of an example?

[fernando-wizeline]

Currently the errors are presented in the results window of the github job right at the end, with all the info as to why they failed the validation.

That sounds fine to me - depending on how good they are we might not need to come back to report generation at all. Any chance you could share a screenshot of an example?

Totally! This is the screenshot:

and the link to the results windows is this: https://github.com/fernando-wizeline/beam/actions/runs/3061434614/jobs/4941196972

[damccorm]

Thanks for sharing - lets definitely skip this for now. Since its a little tough to read that output, I'd like to at least explore options for a nicer report eventually, but it definitely should not block us moving this over to GHA.

[fernando-wizeline]

Thanks for sharing - lets definitely skip this for now. Since its a little tough to read that output, I'd like to at least explore options for a nicer report eventually, but it definitely should not block us moving this over to GHA.

Great! Sounds like a plan. We'll move forward with this and explore alternatives for later implementation. Thanks again Danny!

[fernando-wizeline]

Run Spotless PreCommit

[fernando-wizeline]

Just had one question. Could you please file an issue for the more nicely formatted report as well?

Sure thing, Danny! I will let you know once the issue is created.

[fernando-wizeline]

In jenkins, that task creates a report like the following There are a couple of unofficial plugins that generate a really short status section within github, although not that different from the one already provided by github.

Issue filed here: https://github.com/apache/beam/issues/23466

[github-actions[bot]]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[github-actions[bot]]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[github-actions[bot]]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[damccorm]

Closing as stale