beam icon indicating copy to clipboard operation
beam copied to clipboard

Documented supported PyTorch versions

Open BjornPrime opened this issue 3 years ago • 12 comments

addresses #22206 by adding supporting PyTorch versions in docstrings of PytorchModelHandlerTensor as well as a reminder in tox.ini to update those docstrings if the supported versions of PyTorch change.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

BjornPrime avatar Aug 31 '22 15:08 BjornPrime

@yeandy If you want to triple check things

BjornPrime avatar Aug 31 '22 15:08 BjornPrime

Codecov Report

Merging #22974 (be4a423) into master (d615b62) will decrease coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #22974      +/-   ##
==========================================
- Coverage   73.69%   73.53%   -0.17%     
==========================================
  Files         713      718       +5     
  Lines       94988    95694     +706     
==========================================
+ Hits        70005    70366     +361     
- Misses      23682    24027     +345     
  Partials     1301     1301              
Flag Coverage Δ
python 83.18% <0.00%> (-0.35%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/typehints/__init__.py 77.77% <0.00%> (-22.23%) :arrow_down:
...s/interactive/dataproc/dataproc_cluster_manager.py 71.72% <0.00%> (-5.70%) :arrow_down:
sdks/python/apache_beam/internal/gcp/auth.py 73.33% <0.00%> (-5.34%) :arrow_down:
...python/apache_beam/runners/worker/worker_status.py 74.66% <0.00%> (-5.05%) :arrow_down:
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) :arrow_down:
...dks/python/apache_beam/metrics/monitoring_infos.py 92.50% <0.00%> (-4.50%) :arrow_down:
...ks/python/apache_beam/runners/worker/statecache.py 91.86% <0.00%> (-4.29%) :arrow_down:
sdks/python/apache_beam/internal/pickler.py 92.00% <0.00%> (-3.46%) :arrow_down:
.../apache_beam/runners/interactive/dataproc/types.py 93.10% <0.00%> (-3.45%) :arrow_down:
... and 62 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 31 '22 16:08 codecov[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @y1chi for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Aug 31 '22 18:08 github-actions[bot]

I've made the requested changes.

BjornPrime avatar Sep 01 '22 15:09 BjornPrime

I'm hitting some weird issues with generating the docs. Will post screenshot when I resolve them.

BjornPrime avatar Sep 01 '22 18:09 BjornPrime

remind me after tests pass

tvalentyn avatar Sep 09 '22 16:09 tvalentyn

(that was a command for the bot)

tvalentyn avatar Sep 09 '22 17:09 tvalentyn

Docs tests passed: https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Commit/9732/console

tvalentyn avatar Sep 09 '22 18:09 tvalentyn

Ok - I'll remind @tvalentyn after tests pass

github-actions[bot] avatar Sep 09 '22 18:09 github-actions[bot]

Can you regenerate the docs and post a screenshot of what it looks like now?

@yeandy - did @BjornPrime address these concerns?

tvalentyn avatar Sep 09 '22 18:09 tvalentyn

I can change that.

I could also move the "See https://pytorch.org/tutorials/beginner/saving_loading_models.html for details" line to be just below the Example Usage box so it's consistent with the KeyedTensor docstring.

BjornPrime avatar Sep 14 '22 18:09 BjornPrime

@yeandy Made the requested formatting changes. Still working on getting the docs to build on my machine but can post updated screenshots once I have them.

BjornPrime avatar Sep 16 '22 14:09 BjornPrime

@yeandy Docstrings have been updated, when you have a minute to check them.

BjornPrime avatar Oct 03 '22 19:10 BjornPrime

Updated https://github.com/apache/beam/issues/21104 for current flake. looks unrelated.

tvalentyn avatar Oct 04 '22 17:10 tvalentyn

Thanks everyone.

tvalentyn avatar Oct 04 '22 17:10 tvalentyn