beam icon indicating copy to clipboard operation
beam copied to clipboard

Minor: Add helpful names for parameterized tests in `dataframe.schemas_test`

Open TheNeuralBit opened this issue 2 years ago • 2 comments

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

TheNeuralBit avatar Aug 09 '22 00:08 TheNeuralBit

Codecov Report

Merging #22630 (105b00e) into master (cc0b446) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22630      +/-   ##
==========================================
- Coverage   74.20%   74.19%   -0.02%     
==========================================
  Files         708      708              
  Lines       93462    93462              
==========================================
- Hits        69354    69342      -12     
- Misses      22833    22845      +12     
  Partials     1275     1275              
Flag Coverage Δ
python 83.59% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) :arrow_down:
.../apache_beam/runners/interactive/dataproc/types.py 93.10% <0.00%> (-3.45%) :arrow_down:
...python/apache_beam/runners/worker/worker_status.py 78.26% <0.00%> (-1.45%) :arrow_down:
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) :arrow_down:
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) :arrow_down:
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) :arrow_down:
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (ø)
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) :arrow_up:
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Aug 09 '22 00:08 codecov[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @y1chi for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Aug 09 '22 02:08 github-actions[bot]

@y1chi do you have time to review this? It's pretty small :)

TheNeuralBit avatar Aug 10 '22 16:08 TheNeuralBit