fix minor unreachable code caused by log.Fatal
https://pkg.go.dev/log#Fatalf
Fatalf is equivalent to Printf() followed by a call to os.Exit(1).
see https://go.dev/play/p/iw2MCkHArJZ for example:
package main
import "log"
func main() {
log.Println("Println will print and not exit")
log.Fatalf("Fatalf will print and exit")
log.Println("this line cant reach")
}
/* output:
2009/11/10 23:00:00 Println will print and not exit
2009/11/10 23:00:00 Fatalf will print and exit
Program exited.
*/
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Choose reviewer(s) and mention them in a comment (
R: @username). - [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
R: @lostluck R: @jrmccluskey (just found that you have recently reviewed the go code)
R: @lostluck
R: @jrmccluskey
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
Codecov Report
Merging #22618 (83dd3c5) into master (17fb9c0) will decrease coverage by
0.00%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #22618 +/- ##
==========================================
- Coverage 74.20% 74.20% -0.01%
==========================================
Files 708 710 +2
Lines 93462 93547 +85
==========================================
+ Hits 69355 69414 +59
- Misses 22832 22856 +24
- Partials 1275 1277 +2
| Flag | Coverage Δ | |
|---|---|---|
| go | 51.54% <ø> (+0.02%) |
:arrow_up: |
| python | 83.60% <ø> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| sdks/python/apache_beam/utils/interactive_utils.py | 95.12% <0.00%> (-2.44%) |
:arrow_down: |
| sdks/python/apache_beam/utils/subprocess_server.py | 56.54% <0.00%> (-2.20%) |
:arrow_down: |
| sdks/python/apache_beam/internal/metrics/metric.py | 93.00% <0.00%> (-1.00%) |
:arrow_down: |
| sdks/python/apache_beam/io/localfilesystem.py | 90.97% <0.00%> (-0.76%) |
:arrow_down: |
| ...eam/runners/portability/fn_api_runner/execution.py | 92.44% <0.00%> (-0.65%) |
:arrow_down: |
| sdks/python/apache_beam/runners/direct/executor.py | 96.46% <0.00%> (-0.55%) |
:arrow_down: |
| sdks/python/apache_beam/transforms/combiners.py | 93.05% <0.00%> (-0.39%) |
:arrow_down: |
| sdks/python/apache_beam/coders/coders.py | 88.00% <0.00%> (-0.35%) |
:arrow_down: |
| ...ks/python/apache_beam/runners/worker/sdk_worker.py | 88.94% <0.00%> (-0.16%) |
:arrow_down: |
| sdks/python/apache_beam/transforms/util.py | 96.06% <0.00%> (-0.16%) |
:arrow_down: |
| ... and 16 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more