beam icon indicating copy to clipboard operation
beam copied to clipboard

Fix assertion of global window w/ Non-default trigger w/o allowedLateness

Open mrkm4ntr opened this issue 2 years ago • 3 comments

Following test codes cause java.lang.IllegalArgumentException: Except when using GlobalWindows, calling .triggering() to specify a trigger requires that the allowed lateness be specified using .withAllowedLateness() to set the upper bound on how late data can arrive before being dropped. See Javadoc for more details.

PCollection<Integer> pcollection = pipeline.apply(Create.of(42))
            .apply(Window.<Integer>into(new GlobalWindows())
                    .triggering(AfterPane.elementCountAtLeast(1))
                    .discardingFiredPanes());
PAssert.that(pcollection).inEarlyGlobalWindowPanes().containsInAnyOrder(42);

This is too confusing because I use GlobalWindows.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

mrkm4ntr avatar Aug 03 '22 08:08 mrkm4ntr

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Aug 03 '22 09:08 github-actions[bot]

R: @robertwb

mrkm4ntr avatar Aug 09 '22 05:08 mrkm4ntr

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Aug 09 '22 05:08 github-actions[bot]

@robertwb or @kileys could you take a look?

damccorm avatar Aug 10 '22 21:08 damccorm

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jan 02 '23 12:01 github-actions[bot]

@robertwb or @kileys could you take a look?

mrkm4ntr avatar Jan 08 '23 13:01 mrkm4ntr

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Mar 23 '23 12:03 github-actions[bot]

@robertwb or @klk could you please take a look?

damccorm avatar Mar 23 '23 19:03 damccorm

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 08 '23 12:06 github-actions[bot]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jun 15 '23 12:06 github-actions[bot]