Support Timestamp type in xlang JDBC Read and Write
Part of #19817
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Choose reviewer(s) and mention them in a comment (
R: @username). - [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
Run Python 3.8 PostCommit
Run Python 3.8 PostCommit
Run Python 3.8 PostCommit
Codecov Report
Merging #22561 (b0484e7) into master (0c82583) will increase coverage by
0.04%. The diff coverage is91.30%.
@@ Coverage Diff @@
## master #22561 +/- ##
==========================================
+ Coverage 73.69% 73.73% +0.04%
==========================================
Files 713 713
Lines 94821 94974 +153
==========================================
+ Hits 69874 70030 +156
+ Misses 23648 23645 -3
Partials 1299 1299
| Flag | Coverage Δ | |
|---|---|---|
| python | 83.55% <91.30%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| sdks/python/apache_beam/typehints/schemas.py | 93.84% <89.47%> (-0.31%) |
:arrow_down: |
| sdks/python/apache_beam/coders/row_coder.py | 94.82% <100.00%> (+0.13%) |
:arrow_up: |
| sdks/python/apache_beam/portability/common_urns.py | 100.00% <100.00%> (ø) |
|
| sdks/python/apache_beam/runners/direct/executor.py | 96.46% <0.00%> (-0.55%) |
:arrow_down: |
| ...pi/org/apache/beam/model/pipeline/v1/schema_pb2.py | 100.00% <0.00%> (ø) |
|
| ...g/apache/beam/model/pipeline/v1/schema_pb2_urns.py | 100.00% <0.00%> (ø) |
|
| sdks/python/apache_beam/dataframe/io.py | 89.26% <0.00%> (+<0.01%) |
:arrow_up: |
| ...ks/python/apache_beam/runners/worker/sdk_worker.py | 89.09% <0.00%> (+0.15%) |
:arrow_up: |
| ...hon/apache_beam/runners/worker/bundle_processor.py | 93.79% <0.00%> (+0.49%) |
:arrow_up: |
| sdks/python/apache_beam/io/fileio.py | 96.67% <0.00%> (+0.68%) |
:arrow_up: |
| ... and 4 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Run Python 3.8 PostCommit
Run Python 3.8 PostCommit
test passed: https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/556/testReport/apache_beam.io.external.xlang_jdbcio_it_test/
R: @TheNeuralBit
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
Rebased in order to update CHANGES.md. ready for review now.
Run Python 3.8 PostCommit
Run Python_PVR_Flink PreCommit
Run Java PreCommit
Run Python 3.8 PostCommit
Run Java PreCommit
postcommit test apache_beam.io.external.xlang_jdbcio_it_test.CrossLanguageJdbcIOTest.test_xlang_jdbc_read Failed
Apparently the branch itself works but now failing when merge onto master. Investigating.
Update: related to the change of #22679. After it tests fail.
Rebased onto latest master; the last commit is a fix of test
Run Python 3.8 PostCommit
Run Java PreCommit
Run Python PreCommit
Run Python PreCommit