beam icon indicating copy to clipboard operation
beam copied to clipboard

[Playground] Share any code feature frontend

Open alexeyinkin opened this issue 3 years ago • 2 comments

Resolves #21978.

In this PR:

  • Added 'share any code' feature.
  • Refactored dropdown offset calculation to accommodate the new button.
  • Refactored color theme handling because the new button did not fit the old theme handling.
  • Added ExampleModel.sdk because there are now cases when we can't take it anywhere else, and it also feels natural.
  • Fixed tests, they broke after adding sdk.

Many thanks to @miamihotline who did 70% of the job but was interrupted.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Choose reviewer(s) and mention them in a comment (R: @username).
  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests

See CI.md for more information about GitHub Actions CI.

alexeyinkin avatar Jul 27 '22 18:07 alexeyinkin

R: @damondouglas

alexeyinkin avatar Jul 27 '22 19:07 alexeyinkin

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Jul 27 '22 20:07 github-actions[bot]

lgtm!

pabloem avatar Aug 10 '22 23:08 pabloem