beam icon indicating copy to clipboard operation
beam copied to clipboard

[Website] update contribution content collapse

Open bullet03 opened this issue 2 years ago • 4 comments

Content of Overview and Contribute Code sections was hiding on width between 640px and 768px. Contribute Code section didn't have a correct collalpse html structure.

  • fix Overview and Contribute Code sections, so content collapse works correctly on width 640px and lower
  • update related styles in _list.scss

before: collapse_before

after: collapse_after


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests

See CI.md for more information about GitHub Actions CI.

bullet03 avatar Jul 27 '22 11:07 bullet03

Verified, works as expected. Reviewed and tested by QA

alevtinaboiko avatar Aug 01 '22 06:08 alevtinaboiko

@pcoet, could you kindly review current PR?

bullet03 avatar Aug 04 '22 08:08 bullet03

@aromanenko-dev, this PR was approved. Could you, please, help with merge?

bullet03 avatar Aug 08 '22 10:08 bullet03

Thanks for finding and fixing this!

Was glad to help :-)

bullet03 avatar Aug 08 '22 10:08 bullet03

Sure! Please, don't forget to link it with a proper issue. Thanks

aromanenko-dev avatar Aug 10 '22 16:08 aromanenko-dev

Sure! Please, don't forget to link it with a proper issue. Thanks

Got it. Thank you for reminding and for the help!

bullet03 avatar Aug 11 '22 07:08 bullet03