beam icon indicating copy to clipboard operation
beam copied to clipboard

Implement KafkaSchemaTransformReadConfiguration

Open damondouglas opened this issue 2 years ago • 6 comments

This PR address #21414 with a KafkaSchemaTransformReadConfiguration implementation. It's design goals are to work with a KafkaSchemaTransformReadProvider that extends a TypedSchemaTransformProvider. Subsequent to this PR's approval/merge, the plan is to implement said corresponding KafkaSchemaTransformReadProvider.

Questions remain, however, how to configure the following in the setting of a TypedSchemaTransformProvider:

Due to historically failing beam_PreCommit_Java tests, to validate this PR, I ran the following prior to submission:

./gradlew rat
./gradlew spotlessCheck
./gradlew sdks:java:io:kafka:check
./gradlew sdks:java:io:kafka:checkStyleMain

I would like to request the following to review this PR: R: @pabloem


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Choose reviewer(s) and mention them in a comment (R: @username).
  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • ~Update CHANGES.md with noteworthy changes.~
  • ~If this contribution is large, please file an Apache Individual Contributor License Agreement.~

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests

See CI.md for more information about GitHub Actions CI.

damondouglas avatar Jul 21 '22 21:07 damondouglas

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @apilloud for label java. R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Jul 21 '22 22:07 github-actions[bot]

Reminder, please take a look at this pr: @apilloud @chamikaramj

github-actions[bot] avatar Jul 29 '22 12:07 github-actions[bot]

Looks like you requested @pabloem to review this, but he is out for another week. This really should get reviewed by someone working on IOs. cc: @johnjcasey

apilloud avatar Jul 29 '22 16:07 apilloud

Right now it looks like this is failing to compile, and spotless is also failing.

Can you address these?

johnjcasey avatar Aug 01 '22 13:08 johnjcasey

Right now it looks like this is failing to compile, and spotless is also failing.

Can you address these? Right now it looks like this is failing to compile, and spotless is also failing.

Can you address these?

Hello @johnjcasey Thank you for reviewing.

Are there other gradle commands you might recommend I run to detect where compile and spotless is failing?

The following gradle tasks did not detect errors using the wrong @Nulllable class.

./gradlew rat
./gradlew spotlessCheck
./gradlew sdks:java:io:kafka:check
./gradlew sdks:java:io:kafka:checkStyleMain

damondouglas avatar Aug 01 '22 15:08 damondouglas

I can review this this week. Thanks y'all

pabloem avatar Aug 08 '22 21:08 pabloem

LGTM!

pabloem avatar Aug 12 '22 20:08 pabloem

Run Java PreCommit

pabloem avatar Aug 15 '22 17:08 pabloem

Run Java PreCommit

pabloem avatar Aug 15 '22 20:08 pabloem

thanks @damondouglas !

pabloem avatar Aug 15 '22 23:08 pabloem