beam icon indicating copy to clipboard operation
beam copied to clipboard

Implement PubsubSchemaTransformWriteConfiguration

Open damondouglas opened this issue 3 years ago • 0 comments

This PR address #21412 with a PubsubSchemaTransformWriteConfiguration implementation. It's design goals are to like-for-like replicate PubsubSchemaIOTransform write configuration details. Subsequent to this PR's approval/merge, the plan is to implement the final PubsubSchemaTransformWriteProvider.

Due to repeatedly failing beam_PreCommit_Java tests, to validate this PR, I ran the following prior to submission:

./gradlew rat
./gradlew spotlessCheck
./gradlew sdks:java:io:google-cloud-platform:check
./gradlew sdks:java:io:google-cloud-platform:checkStyleMain

I would like to request the following to review this PR: R: @pabloem


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [x] Choose reviewer(s) and mention them in a comment (R: @username).
  • [x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • ~Update CHANGES.md with noteworthy changes.~
  • ~If this contribution is large, please file an Apache Individual Contributor License Agreement.~

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests

See CI.md for more information about GitHub Actions CI.

damondouglas avatar Jul 13 '22 16:07 damondouglas

lgtm sorry about the delay!

pabloem avatar Aug 12 '22 20:08 pabloem