beam
beam copied to clipboard
Add streaming test for Write API sink
Add streaming test for BigQuery Write API
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Choose reviewer(s) and mention them in a comment (
R: @username). - [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
@chamikaramj Hi Cham, please kindly review the patch.
R: @chamikaramj
R: @pabloem
Run Java PostCommit
@AlexZMLyu please run ./gradlew :sdks:java:io:google-cloud-platform:spotlessApply to format the code and fix spotless issue
Running postcommit that exercises these tests: https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1/1765/
Talked to @pabloem offline. The TestStream class that I used here as the streaming source is not compatible with Dataflow runner. I will edit the code using the GenerateSequence and overriding the expand method to serve as the streaming source instead.
TestStream should work fine on Runner v2, and is preferable.
Robert, thanks for letting me know. Do I need to change my code to utilize the Runner V2?
This test is disabled for Runner v2 currently: https://github.com/apache/beam/blob/67e6726ffeb47d2ada0122369fa230833ce0f026/runners/google-cloud-dataflow-java/build.gradle#L642
Trying to re-enable here: https://github.com/apache/beam/pull/21814
(you can try it on this PR similarly)
Run PostCommit_Java_DataflowV2
There was no failed test in https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV2_PR/112/testReport/ Why the Dataflow V2 Java Post Commit Tests failed?
Do I need to wait for approval of PR #21814 to run Runner v2 here?
Run PostCommit_Java_DataflowV2
Seems like Storage Write API tests are still failing for Runner v2: https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV2_PR/111/testReport/junit/org.apache.beam.sdk.io.gcp.bigquery/BigQueryIOStorageWriteIT/testBigQueryStorageWrite30MProto/
So we can just get the Runner v1 version in (this PR).
Retest this please
Run PostCommit_Java_DataflowV1
Run PostCommit_Java_Dataflow
Run Java PreCommit
Seems like the new tests failed the post-commit test suite: https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/124/
Then I still need to change the streaming source from TestStream to something else, right?
Yeah, I think it's probably ok to use GenerateSequence (a bounded source) for a simple integration test that use the streaming Runner v1. Separately we should check why this still failed for Runner v2.
Run PostCommit_Java_DataflowV1
Run PostCommit_Java_DataflowV1
Run Spotless PreCommit