beam icon indicating copy to clipboard operation
beam copied to clipboard

Python AfterAny, AfterAll do not follow spec

Open damccorm opened this issue 2 years ago • 5 comments

Both AfterAll and AfterAny should complete after firing, but they base their logic on the subtriggers, but they instead only finish if all the fired subtriggers or any of the fired subtriggers finish. This makes it possible for them to never finish.

For more info, see discussion in https://github.com/apache/beam/pull/15603

Imported from Jira BEAM-13076. Original Jira may contain additional context. Reported by: zhoufek.

damccorm avatar Jun 04 '22 22:06 damccorm

@zhoufek did you follow up with this, or is it still outstanding?

kennknowles avatar Sep 13 '22 22:09 kennknowles

I've been looking into this, and it is starting to seem like python triggers need to be reworked to some extent

johnjcasey avatar Oct 25 '22 16:10 johnjcasey

it looks like afterAny simply doesn't fire correctly at all, and has never done so

johnjcasey avatar Oct 25 '22 16:10 johnjcasey

@johnjcasey are you working on this still?

kennknowles avatar Dec 07 '22 16:12 kennknowles

I am not, I wasn't able to understand how python triggers work (or dont) in the fixit week.

johnjcasey avatar Dec 07 '22 18:12 johnjcasey