avro icon indicating copy to clipboard operation
avro copied to clipboard

AVRO-1856 concat tool append to input

Open MikeHurleySurescripts opened this issue 8 years ago • 4 comments

Let me know if this pull request should be pointed to a different branch.

MikeHurleySurescripts avatar Jun 01 '16 14:06 MikeHurleySurescripts

just noticed this:

Let me know if this pull request should be pointed to a different branch.

Generally, PRs should target the master branch. In this case I'll take care of moving from 1.8 to master, presuming it doesn't explode.

busbey avatar Jul 05 '16 15:07 busbey

👍 I'll leave this open for additional comments over the next day or two, and will then merge it in time for 1.8.2 RCs.

busbey avatar Jul 05 '16 15:07 busbey

@busbey, do you want to merge this?

rdblue avatar Sep 04 '16 20:09 rdblue

@MikeHurleySurescripts I tried to merge this on Avro master branch, but had merge conflicts, could you please apply this patch on top of the latest master branch and update the pull request accordingly? Also, Checkstyle is complaining due to trailing whitespaces, so build is broken: /Users/nkollar/work/upstream/avro/lang/java/tools/src/main/java/org/apache/avro/tool/Util.java:137: Line matches the illegal pattern 'Trailing whitespace', could you please delete the problematic whitespaces? Otherwise looks good to me!

nandorKollar avatar Jun 30 '17 15:06 nandorKollar