avro icon indicating copy to clipboard operation
avro copied to clipboard

AVRO-2640: add useFieldNameForGetter option to SpecficCompiler

Open ecopoesis opened this issue 5 years ago • 0 comments

Adds the useFieldNameForGetter option to SpecificCompiler. When enabled, SpecificCompile will now use the field names without the 'get' prefix as the name of the getter for that field.

Make sure you have checked all steps below.

Jira

  • [x] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
    • https://issues.apache.org/jira/browse/AVRO-2640
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

testFieldNameForGetter testFieldNameForGetterReturnsOptional testFieldNameForGetterCompiles testFieldNameForGetterReturnsOptionalCompiles

Commits

  • [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • [x] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

ecopoesis avatar Nov 26 '19 20:11 ecopoesis