avro icon indicating copy to clipboard operation
avro copied to clipboard

AVRO-2401:Initializing decimal fields with fixed can casue padding issues

Open zeshuai007 opened this issue 5 years ago • 1 comments

Make sure you have checked all steps below.

Jira

  • [x] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
    • https://issues.apache.org/jira/browse/AVRO-2401
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • [ ] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

zeshuai007 avatar Nov 26 '19 08:11 zeshuai007

Hmmm -- this changes the behaviour for all fixed types with schemas, not just Decimal logical types. I'm not sure what that impact would be.

I'd be tempted to think that the right thing to do is to just throw an exception if the default size doesn't match the schema in terms of size... I know we tightened up the requirements for defaults in 1.9.x. What do you think?

RyanSkraba avatar Nov 26 '19 16:11 RyanSkraba