apache
AVRO-3936: Clean up NOTICE and LICENSE file
- https://issues.apache.org/jira/browse/AVRO-1769 https://svn.apache.org/viewvc?view=revision&revision=1725901 The implementation of Jansson has been removed.
- https://github.com/apache/avro/pull/307 The implementation of nunit.framework.dll,Newtonsoft.Json.dll and Castle.Core.dll has been removed.
- https://github.com/apache/avro/pull/2756/ The implementation of m4 macros has been removed.
- https://github.com/apache/avro/commit/8a42cd0642fcadca7765f59d83a059b1eddb26bd The implementation of Boost.hh has been removed.
Contribution Checklist
-
Make sure that the pull request corresponds to a JIRA issue. Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
-
Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where AVRO-XXXX should be replaced by the actual issue number. The component is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
Newtonsoft.Json.dll is still being distributed within the Apache.Avro.Tools NuGet package. Perhaps that package should have a separate NOTICE file, because it includes third-party files that are not in the Apache.Avro package.
Newtonsoft.Json.dll is still being distributed within the Apache.Avro.Tools NuGet package. Perhaps that package should have a separate NOTICE file, because it includes third-party files that are not in the Apache.Avro package.↳
oops, could you clarify exactly which file you're referring to? I couldn't seem to find this package.
From https://www.nuget.org/packages/Apache.Avro.Tools/1.12.0, click Download package, and use unzip -l apache.avro.tools.1.12.0.nupkg; it shows tools/net8.0/any/Newtonsoft.Json.dll, and similar files in other directories.
Or if your Web browser supports WebAssembly, then click Open in NuGet Package Explorer, wait until it has loaded the package, and navigate to tools > net80 > any in the "Contents" pane at the top right; it shows a Newtonsoft.Json.dll file there.
The LICENSE file in that package includes the Json.NET license notice. Will that one still be there after this pull request?
It looks like the LICENSE file in the Apache.Avro.Tools NuGet package comes from lang/csharp/LICENSE, which is not modified in this pull request. So, the Json.NET license notice will remain in that package.
lang/csharp/LICENSE also includes legal notices for Castle Core and log4net. I don't know whether those are still relevant.
It looks like the
LICENSEfile in the Apache.Avro.Tools NuGet package comes from lang/csharp/LICENSE, which is not modified in this pull request. So, the Json.NET license notice will remain in that package.↳lang/csharp/LICENSE also includes legal notices for Castle Core and log4net. I don't know whether those are still relevant.↳
I'm not familiar with C#, but this appears to be a binary package (which includes DLL files). Where does its source code come from? Also, this change only involves the LICENSE file in the source package.
lang/csharp/src/apache/codegen/Avro.codegen.csproj is the C# project file for the Apache.Avro.Tools NuGet package. It gets the Newtonsoft.Json.dll files from the Newtonsoft.Json NuGet package, instead of building them from source.
The changes in this pull request look all right to me, but it might be appropriate to also remove the Castle Core and log4net notices from lang/csharp/LICENSE, if Avro no longer references those libraries.
In contrast, the Newtonsoft.Json notices should not be removed from lang/csharp/LICENSE. And this PR does not remove them.
lang/csharp/src/apache/codegen/Avro.codegen.csprojis the C# project file for the Apache.Avro.Tools NuGet package. It gets theNewtonsoft.Json.dllfiles from the Newtonsoft.Json NuGet package, instead of building them from source.↳The changes in this pull request look all right to me, but it might be appropriate to also remove the Castle Core and log4net notices from
lang/csharp/LICENSE, if Avro no longer references those libraries.↳In contrast, the Newtonsoft.Json notices should not be removed from
lang/csharp/LICENSE. And this PR does not remove them.
This tool is something we released? It seems to lack a NOTICE file, and the binary distribution still needs to comply with the AL2 requirements. I'm not familiar with C#, so I'm unable to determine whether the LICENSE file is correct, specifically if it includes the licenses for the bundled components.