avro icon indicating copy to clipboard operation
avro copied to clipboard

AVRO-4051: Remove Superfluous Increments

Open belugabehr opened this issue 1 year ago • 2 comments

What is the purpose of the change

  • Trivial change to remove needless operations - faster ops, smaller package.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

This change added tests and can be verified as follows:

  • Reviewed decompiled version to verify increments were no longer present

Documentation

  • Does this pull request introduce a new feature? no

belugabehr avatar Sep 02 '24 03:09 belugabehr

faster ops

Do benchmark results show such an effect? The code looks like a JIT bytecode-to-machinecode compiler should be able to replace all the uses of i with constants anyway, even if the Java-to-bytecode compiler doesn't do that.

KalleOlaviNiemitalo avatar Sep 02 '24 03:09 KalleOlaviNiemitalo

By i I mean len 😞

KalleOlaviNiemitalo avatar Sep 02 '24 03:09 KalleOlaviNiemitalo