apache
AVRO-3933: Unify ARM64 workflows
What is the purpose of the change
Unify ARM64 build workflows (AVRO-3933)
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
@martin-g This PR is a POC to unify the ARM64 workflow with the regular x64 based workflow. The most important thing is that the same (as much as possible) worklfow is used for x64 and ARM64 (using build matrix).
@nielsbasjes Not sure if this PR is a step back for your issue yesterday
I'm fine with this step as soon as the ARM build servers are reliable.
Are these servers reliable now? If not yet then I think this should wait till they are.
Note that the README.md also needs changes as part of this merge request.
Roger. So based on your PR you just wanted simply make it visible that ARM failed, so we can ignore it (since it is an issue of the self hosted runner)
Using the github hosted macos-14 runner is an option, however that is a MacOS image with ARM64 M1 processor. Not Ubuntu like the other runners we use, so most likely a good amount work would be needed to make everything build on MacOS. But, that would remove the external build server dependency.
Roger. So based on your PR you just wanted simply make it visible that ARM failed, so we can ignore it (since it is an issue of the self hosted runner)
Yes exactly. Before my patch it showed that the Java build failed. A deeper dive into the logging was needed to reveal that it was the ARM runner ... again.
With this split this became easier to inspect.
I fully like your approach to consolidate the builds over all architectures. If I understand correctly; Going the macos route would mean having them all separate again?
Apparently simply having this in Github Actions has been a feature request for about 2 years now https://github.com/actions/runner-images/issues/5631
Yeah, it is a big missing piece from Github. Hopefully soon it is released. Github announced last year that ARM runners are coming this year.
https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions/